ci(template): build cargo-audit against stable rust toolchain#612
Merged
Conversation
The daily security audit builds cargo-audit from source using the toolchain pinned in rust-toolchain.toml. A transitive build dependency (kstring 2.0.4) now requires Rust 1.96.0, which is newer than the pinned channel, so the build fails and the audit never runs. Override RUSTUP_TOOLCHAIN=stable for the audit step so cargo-audit is built with current stable. The toolchain used to build the tool does not affect the audit result, so this is safe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dervoeti
approved these changes
Jul 20, 2026
dervoeti
left a comment
dervoeti
left a comment
Member
There was a problem hiding this comment.
LGTM
We can think about making these failures visible in SecObserve in the future or moving this check to somewhere else (like our daily scanning of the release images). Not urgent though, can be part of a future rework.
dervoeti
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The daily security audit has been failing for a couple of days because a dependency of
cargo-audit(kstring) now requires Rust 1.96.0 to build. See one example(
general_daily_security.yml)This PR makes it so that cargo-audit builds against the current stable version instead of our pinned one.
I'm fairly certain this fixes the issue itself but the cost will be a slightly longer runtime because it needs to download the second toolchain I guess. Opinions welcome.
Edit: I just realize that runtime doesn't matter much for the nightly cron job...
@StefanFl @dervoeti Not sure if we even still want/need these runs at all?